release-22.1: sql: hide number of placeholder #88364
Merged
+90
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #88215 on behalf of @maryliag.
/cc @cockroachdb/release
Previously, placeholder values were kept as is
for fingerprint creation, meaning
IN ($1, $2)
would be a different fingerprint than
IN ($2, $1)
even though they should be the same.This commit replace all placeholder values with
$1
, so wecan still know it was a placeholder, but we don't care about the
number of the placeholder itself.
This is the simplest solution to solve this problem. Other
options (e.g. replace with
$_
orp_
) were considered butultimately they would require other modification on the parser code
to accept these values.
Previously:
SELECT * FROM t WHERE v IN ($1, $2)
->SELECT * FROM t WHERE v IN ($1, $2)
SELECT * FROM t WHERE v IN ($2, $1)
->SELECT * FROM t WHERE v IN ($2, $1)
Now:
SELECT * FROM t WHERE v IN ($1, $2)
->SELECT * FROM t WHERE v IN ($1, $1)
SELECT * FROM t WHERE v IN ($2, $1)
->SELECT * FROM t WHERE v IN ($1, $1)
Fixes #88074
Release note (sql change): The index of a placeholder
is now replaced to always be
$1
to limit fingerprint creations.Release justification: low risk, high benefit change